Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing querying of historic job data #511

Closed
wants to merge 2 commits into from

Conversation

JAllen42
Copy link
Contributor

@JAllen42 JAllen42 commented Oct 10, 2023

Linked to cylc/cylc-ui#1510

This is a branch for querying historic job data. You can give it a list of task names to limit which jobs are returned, otherwise it will default to all jobs.

image

This is a quick work in progress branch that I have used for development of UI views to visualise job timing data and wants tidying up before it is ready to go on master.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (1433411) 75.42% compared to head (b779063) 73.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   75.42%   73.60%   -1.82%     
==========================================
  Files          12       12              
  Lines        1428     1474      +46     
  Branches      236      250      +14     
==========================================
+ Hits         1077     1085       +8     
- Misses        301      339      +38     
  Partials       50       50              
Files Coverage Δ
cylc/uiserver/schema.py 58.94% <17.02%> (-13.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

raise Exception('At least one workflow must be provided.')
from cylc.flow.rundb import CylcWorkflowDAO
from cylc.flow.pathutil import get_workflow_run_dir
from cylc.flow.workflow_files import WorkflowFiles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend to put these at the top? They would be imported every time the query/field is requested otherwise

@ChrisPaulBennett
Copy link
Contributor

I'm taking over this issue. Please see
#530
I'm just sorting out the test coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants