Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: replace httptest with httptest2 as gh now uses httr2 instead of httr #646

Merged
merged 3 commits into from
Mar 7, 2023
Merged

tests: replace httptest with httptest2 as gh now uses httr2 instead of httr #646

merged 3 commits into from
Mar 7, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Mar 6, 2023

Fix #642

maelle
maelle commented Mar 6, 2023
View reviewed changes
tests/testthat/helper-httptest2.R
@@ -0,0 +1,5 @@
library("httptest2")

with_mock_dir <- function(name, ...) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided it was cleaner to have fixtures in their own folder.

@maelle maelle requested a review from krlmlr March 6, 2023 13:49
@krlmlr krlmlr merged commit d1a9f98 into main Mar 7, 2023
@krlmlr krlmlr deleted the test-fix branch March 7, 2023 06:43
@krlmlr
Copy link
Contributor

krlmlr commented Mar 7, 2023

Thanks!

@maelle maelle mentioned this pull request Mar 10, 2023
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr Awaiting requested review from krlmlr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current test failures
2 participants
@maelle @krlmlr