-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests #44
tests #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
DESCRIPTION
Outdated
@@ -47,6 +47,7 @@ Imports: | |||
Suggests: | |||
daff, | |||
knitr, | |||
pkgload, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we need this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R CMD check produces a warning otherwise, cause pkgload::load_all()
is used in example/swc_get_mapping.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example file shouldn't use it either.
Co-authored-by: Kirill Müller <[email protected]>
think the Windows tests should now work with 4edd1bb -- currently failing due to https://chocolatey.org/api/v2/ being down for maintenance, checking later again. |
this seems ok now to me. |
I removed the obvious dependencies on {pkgload}; now I can't find any mention of {pkgload} anywhere, but the tests are still complaining that an apparent dependency isn't acknowledged. |
It's tricky. PRs are checked using a synthetic commit where the source branch is merged into the target branch: https://github.com/cynkra/munch/pull/44/checks?check_run_id=2237415606#step:3:394. The main branch was ahead and contained the evil pkgload line. I think it's fine to use pkgload in the |
To recover, |
We really need to merge main into this branch to avoid losing our minds. |
Sorry for the mess... when I locally merge |
The main branch is called main. |
...in this repo. |
you're right, I meant main; seems to be good now. |
Thanks! |
closes #31