Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add explicit check against codeCoverage.expectFrontendCoverageOnly before attempting to collect backend coverage #555

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add explicit check against codeCoverage.expectFrontendCoverageOnly before attempting to collect backend coverage #555

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10c86e6
feat: add explicit check against codeCoverage.expectFrontendCoverageO…
eulersson Mar 15, 2022
122a527
Run Prettier.
eulersson Mar 15, 2022
8f3fc42
Merge branch 'master' into master
jennifer-shehane Nov 15, 2023
d073a21
Merge remote-tracking branch 'upstream/master'
eulersson Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,19 @@ const registerHooks = () => {
const baseUrl = Cypress.config('baseUrl') || cy.state('window').origin
// @ts-ignore
const runningEndToEndTests = baseUrl !== Cypress.config('proxyUrl')
const expectFrontendCoverageOnly = Cypress._.get(
Cypress.env('codeCoverage'),
'expectFrontendCoverageOnly',
false
)
const specType = Cypress._.get(Cypress.spec, 'specType', 'integration')
const isIntegrationSpec = specType === 'integration'

if (runningEndToEndTests && isIntegrationSpec) {
if (
!expectFrontendCoverageOnly &&
runningEndToEndTests &&
isIntegrationSpec
) {
// we can only request server-side code coverage
// if we are running end-to-end tests,
// otherwise where do we send the request?
Expand Down