chore(deps): remove underscore and backbone as dev dependencies (#…

…16407) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]>
cypress-io · May 10, 2021 · 3e3b9df · 3e3b9df · cypress-bot · May 10, 2021
1 parent 2b0add1
commit 3e3b9df
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 47 deletions.
diff --git a/packages/driver/cypress/fixtures/issue-652.html b/packages/driver/cypress/fixtures/issue-652.html
@@ -1,39 +1,23 @@
 <html>
-    <head>
-        <title>Bb Router</title>
-        <script src="/node_modules/jquery/dist/jquery.js"></script>
-        <script src="/node_modules/underscore/underscore.js"></script>
-        <script src="/node_modules/backbone/backbone.js"></script>
-    </head>
     <body>
-        <a href="#one">one</a> <a href="#two">two</a> <a href="#three">three</a>
+        <a href="#one">one</a> 
+        <a href="#two">two</a> 
+        <a href="#three">three</a>
         <div id="visited"></div>
         <script>
-            var Workspace = Backbone.Router.extend({
+            const visitedLink = document.getElementById('visited')
 
-                routes: {
-                    "one": "one",
-                    "two": "two",
-                    "three": "three"
-                },
-
-                one: function() {
-                    $('#visited').append('<div>one</div>');
-                },
-
-                two: function() {
-                    $('#visited').append('<div>two</div>');
-                },
-
-                three: function() {
-                    $('#visited').append('<div>three</div>');
+            window.addEventListener("hashchange", function () {
+                if (location.hash === '#one') {
+                  visitedLink.append('one');
                 }
-            });
-
-            new Workspace();
-
-            Backbone.history.start();
-
+                if (location.hash === '#two') {
+                  visitedLink.append('two');
+                }
+                if (location.hash === '#three') {
+                  visitedLink.append('three');
+                }
+            })
         </script>
     </body>
 </html>
diff --git a/packages/driver/cypress/integration/issues/652_spec.js b/packages/driver/cypress/integration/issues/652_spec.js
@@ -5,11 +5,8 @@ describe('issue 652', () => {
   })
 
   it('should visit all the hashes', () => {
-    // cy.wait(0)
     cy.visit('/fixtures/issue-652.html#one')
-    // cy.wait(0)
     cy.visit('/fixtures/issue-652.html#two')
-    // cy.wait(0)
     cy.visit('/fixtures/issue-652.html#three')
 
     cy.get('#visited')

diff --git a/packages/driver/package.json b/packages/driver/package.json
@@ -27,7 +27,6 @@
     "@types/lodash": "^4.14.168",
     "@types/mocha": "^8.0.3",
     "angular": "1.8.0",
-    "backbone": "1.4.0",
     "basic-auth": "2.0.1",
     "blob-util": "2.0.2",
     "bluebird": "3.5.3",
@@ -69,7 +68,6 @@
     "sinon": "8.1.1",
     "source-map": "0.8.0-beta.0",
     "text-mask-addons": "3.8.0",
-    "underscore": "1.9.1",
     "underscore.string": "3.3.5",
     "unfetch": "4.1.0",
     "url-parse": "1.4.7",

diff --git a/packages/server/package.json b/packages/server/package.json
@@ -115,7 +115,6 @@
     "trash": "5.2.0",
     "tree-kill": "1.2.2",
     "ts-node": "8.5.4",
-    "underscore": "1.9.1",
     "underscore.string": "3.3.5",
     "url-parse": "1.4.7",
     "uuid": "8.3.2",

diff --git a/yarn.lock b/yarn.lock
@@ -10915,13 +10915,6 @@ bach@^1.0.0:
     async-settle "^1.0.0"
     now-and-later "^2.0.0"
 
-[email protected]:
-  version "1.4.0"
-  resolved "https://registry.yarnpkg.com/backbone/-/backbone-1.4.0.tgz#54db4de9df7c3811c3f032f34749a4cd27f3bd12"
-  integrity sha512-RLmDrRXkVdouTg38jcgHhyQ/2zjg7a8E6sz2zxfz21Hh17xDJYUHBZimVIt5fUyS8vbfpeSmTL3gUjTEvUV3qQ==
-  dependencies:
-    underscore ">=1.8.3"
-
 [email protected], backo2@~1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/backo2/-/backo2-1.0.2.tgz#31ab1ac8b129363463e35b3ebb69f4dfcfba7947"
@@ -35713,10 +35706,10 @@ [email protected]:
     sprintf-js "^1.0.3"
     util-deprecate "^1.0.2"
 
-underscore@1.9.1, underscore@>=1.8.3, underscore@^1.8.3:
-  version "1.9.1"
-  resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.9.1.tgz#06dce34a0e68a7babc29b365b8e74b8925203961"
-  integrity sha512-5/4etnCkd9c8gwgowi5/om/mYO5ajCaOgdzj/oW+0eQV9WxKBDZw5+ycmKmeaTXjInS/W0BzpGLo2xR2aBwZdg==
+underscore@^1.8.3:
+  version "1.12.1"
+  resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.12.1.tgz#7bb8cc9b3d397e201cf8553336d262544ead829e"
+  integrity sha512-hEQt0+ZLDVUMhebKxL4x1BTtDY7bavVofhZ9KZ4aI26X9SRaE+Y3m83XUL1UP2jn8ynjndwCCpEHdUG+9pP1Tw==
 
 underscore@~1.6.0:
   version "1.6.0"