Problem cancelling XHRs from previous test #761

AshMcConnell · 2017-10-18T10:26:21Z

Current behavior:

Yep, there is an issue if you don't wait for all XHRs to finish after a test. When it tries to cancel the XHR it fails with the error: -

UnsubscriptionError: 1 errors occurred during unsubscription:
  1) TypeError: Cannot set property 'aborted' of undefined

if I do an explicit cy.wait(2000) or cy.wait('@myxhr') it works
note it's the following test that fails, not the one with the XHR

Desired behavior:

The XHR should be cancelled correctly before the next test starts

How to reproduce:

Have a longish running XHR fire at the end of one test and have a subsequent test.

Additional Info (images, stack traces, etc)

It seems to happen when I am faking a route failure (status 500) and then make another (non-faked) XHR (to report the error to a server). e.g.: -

cy.route({
  method: 'PUT',
  url: '/Endpoint/Id',
  status: 500,
  response: ''
}).as('saveStuff');

Operating System: Ubuntu 16.04
Cypress Version: 1.0.2
Browser Version: Electron 53

The text was updated successfully, but these errors were encountered:

brian-mann · 2017-10-18T17:22:23Z

Related to #686 and almost a duplicate, but I'll leave this open for now until I can confirm it is.

Mende · 2017-11-03T15:12:35Z

Same issue.
Cypress CLI: 0.13.1
Cypress App: 0.19.2
Electron 53
Mac OS X Sierra

brian-mann · 2017-11-03T16:51:30Z

We no longer abort XHR's in between tests.

This was actually fixed in 0.20.0 and I forgot to close this issue then.

daniil-g-8sph · 2017-11-19T23:57:23Z

@brian-mann I still have the problem in 1.0.3 (Chrome 62, Electron 53 in both)

cypress_runner.js:136633 TypeError: Cannot set property 'aborted' of undefined
    at XMLHttpRequest.XHR.abort (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:65539:23)
    at XMLHttpRequest.onReadyStateFn (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:65617:27)
From previous event:
    at run (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:61887:15)
    at Object.cy.(anonymous function) [as visit] (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:62107:11)
    at Context.runnable.fn (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:62238:20)
    at callFn (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:32092:21)
    at Test.Runnable.run (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:32085:7)
    at https://spb.tele2.ru/__cypress/runner/cypress_runner.js:65090:28
From previous event:
    at Object.onRunnableRun (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:65089:20)
    at $Cypress.action (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:60592:51)
    at Test.Runnable.run (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:64240:20)
    at Runner.runTest (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:32555:10)
    at https://spb.tele2.ru/__cypress/runner/cypress_runner.js:32661:12
    at next (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:32475:14)
    at https://spb.tele2.ru/__cypress/runner/cypress_runner.js:32485:7
    at next (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:32417:14)
    at https://spb.tele2.ru/__cypress/runner/cypress_runner.js:32453:5
    at timeslice (https://spb.tele2.ru/__cypress/runner/cypress_runner.js:27694:27)
logError @ cypress_runner.js:136633

TopWebGhost · 2017-12-13T03:32:38Z

I have the same problem

wijwoj · 2017-12-18T09:46:39Z

I'm getting these errors when calling visit on a new url after running over from one test spec file to the next.

Currently having to do something nasty like:

Cypress.on('uncaught:exception', (err, runnable) => {
    return err.message.indexOf('Cannot set property \'aborted\' of undefined') === -1
});

tan-nhu · 2018-01-17T18:41:42Z

I'm facing the same problem with cypress 1.4.1.

shcallaway · 2018-02-16T00:20:29Z

I am also experiencing this with 1.4.2. I am not making any requests or even repeating cy.visit at the beginning of each test. I also don't see any aborted XHRs in the Cypress sidebar or failed requests in the Chome Dev Tools.

adrinr · 2018-02-16T14:42:07Z

Having the same problem with 1.4.1. Did somebody find some workaround?

dracos · 2018-03-26T13:29:10Z

Just to add still happening for us in 2.1.0, we've added an extra cy.visit("/") to make sure whatever was in progress is aborted.

rafaelchiti · 2018-03-27T23:51:01Z

@dracos where did you add the cy.visist("/")? I'm trying all the combinations possible and still having issues. In my case I have pub nub configured in the app. I'm trying to 'disable it' but wondering if this should work out of the box. Just came from TestCafe and this seemed to work just fine, wondering how they handle it. Thanks!!

dracos · 2018-03-28T06:51:32Z

@rafaelchiti At the end of the test that caused the next test to fail, went for a 404 in the end. See the cleanUpXHR function in https://github.com/mysociety/fixmystreet/blob/ed6c2501/.cypress/cypress/integration/regressions.js - hope that's helpful.

mparpaillon · 2018-04-03T09:19:52Z

@brian-mann If you no longer abort XHRs between tests how come we all still get this error ? I'm using 2.1.0 and I keep having this problem. Thanks

royston-c · 2018-04-27T11:59:43Z

@rafaelchiti did you have any success with the PubNub long polling and Cypress? Some of the functionality i want to test is dependent on it so I don't really want to stub it out.

rafaelchiti · 2018-04-27T12:11:46Z

mm I managed to get it going but seemed a bit off the stuff I had to do. Let me share the example here. I followed what dracos suggested. Either way I didn't experiment much, after this I switched to Test Cafe (due to other company requirements).

My test would have this:

  beforeEach(() => {
    cy.visit(Cypress.env("yourAppUrl"));
  });

  afterEach(() => {
    cy.cleanUpXHR();
  });

my commands.js

Cypress.Commands.add("cleanUpXHR", function() {
  if (Cypress.env("run_all_suite")) {
    cy.visit(`${Cypress.env("yourAppUrl")}/404`, { failOnStatusCode: false });
  }

my make file for running them:

test-cypress-open:
	cd test/e2e && npx cypress open

test-cypress-run:
	cd test/e2e && npx cypress run --env run_all_suite=true

I only executed the clean up when running the whole suite. When working on 1 test with the visual debugger I didn't want that behavior to kick in, since that visual debugger is sort of meant for working on one test at a time (from what I understand) and not to run multiple tests.
I didn't try but that is the latest I found in my repo I think that was the solution that ended up working.

StormPooper · 2018-05-25T15:27:58Z

Also seeing this with 2.10, but the extra page visit after the tests only fixes it most of the time, plus it adds time to each test to visit the extra page.

pperry-atlassian · 2018-05-25T15:43:33Z

Same here. Similar to @rafaelchiti and @roy46, our app has long polling requests that will trigger this error on every spec. I didn't have any luck at all with an afterEach hook, so I had to add a command as the last step in every spec to route to a static 404 html page. It slows the suites down since every spec has to reload the page.

StormPooper · 2018-05-31T08:37:43Z

Still an issue with 3.0.1 too.

jechlin · 2018-06-08T11:30:19Z

I was getting this too but only on test failures, which made it very hard to debug. In my case it turned out to be through using:

this.retries(1)

in an attempt to get it to retry failing tests once... this is a mocha thing that turned out never worked anyway, but I accidentally left it in. This caused the problem... maybe related upgrading to 3.0.1 but I doubt it.

amenk · 2018-12-06T14:18:55Z

@jennifer-shehane How is the status of this, now having a reproducible example?

- fixes #761 - fixes #1652 - fixes #2968

mlc-mlapis · 2018-12-20T08:13:32Z

@brian-mann ... thank you, Brian.

jennifer-shehane · 2018-12-20T08:30:55Z

The code for this is done, but this has yet to be released. We'll update this issue and reference the changelog when it's released.

brian-mann · 2018-12-26T08:30:38Z

Released in 3.1.4.

tomaass · 2019-01-02T15:19:09Z

Hi, I'm using rxjs and redux-obsevables in my app. There was no problem in Cypress 3.1.2 with aborting requests by takeUntil operator from rxjs. But after upgrade to 3.1.4 I sometimes have an error like:

Error: Failed to read the 'responseText' property from 'XMLHttpRequest': The value is only accessible if the object's 'responseType' is '' or 'text' (was 'json').

I think it's caused by solving this 🐛

mlc-mlapis · 2019-01-02T16:38:44Z

@tomaass ... as always ... without a simple reproduction demo, it's hard to guess.

tomaass · 2019-01-03T08:58:20Z

@mlc-mlapis example of aborting request by using rxjs and redux-observables ;-)

const exampleEpic = action$ =>
  action$.ofType(FETCH_ACTION)
    .switchMap(() =>
      Observable.ajax.getJSON('example.url')
        .takeUntil(action$.ofType(ANOTHER_ACTION))
        .map(fetchExampleFulfilled)

If ANOTHER_ACTION comes before a response from a server it aborts the request and an error was thrown.
If another FETCH_ACTION comes before a response from a server it does the same after aborting

mlc-mlapis · 2019-01-03T09:24:02Z

@tomaass ... which RxJS version is used here? Because I can't see pipe-able operators.

jennifer-shehane · 2019-01-03T10:51:34Z

Hey @tomaass, this is a bug introduced in 3.1.4 - documented here: #3008

nabby27 · 2019-12-05T09:13:27Z

Hey, I can solve it with cy.wait(100) before cy.visit()

jennifer-shehane · 2020-01-02T07:20:43Z

This issue will be closed to further comment as the exact issue here was resolved and tested.

If you're experiencing a bug similar to this in Cypress, please open a new issue with a fully reproducible example that we can run. There may be a specific edge case with the issue that we need more detail to fix.

brian-mann mentioned this issue Oct 18, 2017

Enable Lifecycle Events to be customizable #686

Closed

brian-mann self-assigned this Oct 18, 2017

jennifer-shehane added the stage: needs investigating Someone from Cypress needs to look at this label Oct 19, 2017

jennifer-shehane added the type: bug label Nov 3, 2017

brian-mann closed this as completed Nov 3, 2017

brian-mann added this to the 0.20.0 milestone Nov 3, 2017

RandallKent reopened this Nov 25, 2017

This comment has been minimized.

Sign in to view

mihalik mentioned this issue Feb 19, 2018

Avoid modifying XHR proxy that no longer exists #1345

Closed

jennifer-shehane removed this from the 0.20.0 milestone Jun 1, 2018

jennifer-shehane assigned lilaconlee and brian-mann and unassigned chrisbreiding, brian-mann and lilaconlee Nov 26, 2018

jennifer-shehane added difficulty: 2️⃣ labels Dec 7, 2018

brian-mann mentioned this issue Dec 19, 2018

fix issues around aborted xhrs #2969

Merged

jennifer-shehane modified the milestones: Sprint 13, Sprint 16 Dec 19, 2018

jennifer-shehane added stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Dec 19, 2018

brian-mann closed this as completed in #2969 Dec 19, 2018

brian-mann added a commit that referenced this issue Dec 19, 2018

fix issues around aborted xhrs (#2969)

4dcc738

- fixes #761 - fixes #1652 - fixes #2968

jennifer-shehane added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Dec 20, 2018

danhaasalert mentioned this issue Dec 23, 2018

Return Promise issues #2979

Closed

jennifer-shehane removed the stage: pending release label Dec 26, 2018

cypress-io locked as resolved and limited conversation to collaborators Jan 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem cancelling XHRs from previous test #761

Problem cancelling XHRs from previous test #761

AshMcConnell commented Oct 18, 2017 •

edited by jennifer-shehane

Loading

brian-mann commented Oct 18, 2017

Mende commented Nov 3, 2017

brian-mann commented Nov 3, 2017

daniil-g-8sph commented Nov 19, 2017 •

edited by jennifer-shehane

Loading

TopWebGhost commented Dec 13, 2017

wijwoj commented Dec 18, 2017 •

edited by jennifer-shehane

Loading

tan-nhu commented Jan 17, 2018

This comment has been minimized.

This comment has been minimized.

shcallaway commented Feb 16, 2018 •

edited

Loading

adrinr commented Feb 16, 2018

dracos commented Mar 26, 2018

rafaelchiti commented Mar 27, 2018 •

edited

Loading

dracos commented Mar 28, 2018

mparpaillon commented Apr 3, 2018

royston-c commented Apr 27, 2018

rafaelchiti commented Apr 27, 2018

StormPooper commented May 25, 2018

pperry-atlassian commented May 25, 2018

StormPooper commented May 31, 2018

jechlin commented Jun 8, 2018

amenk commented Dec 6, 2018

mlc-mlapis commented Dec 20, 2018 •

edited

Loading

jennifer-shehane commented Dec 20, 2018

brian-mann commented Dec 26, 2018

tomaass commented Jan 2, 2019

mlc-mlapis commented Jan 2, 2019

tomaass commented Jan 3, 2019 •

edited

Loading

mlc-mlapis commented Jan 3, 2019

jennifer-shehane commented Jan 3, 2019

nabby27 commented Dec 5, 2019

jennifer-shehane commented Jan 2, 2020

Problem cancelling XHRs from previous test #761

Problem cancelling XHRs from previous test #761

Comments

AshMcConnell commented Oct 18, 2017 • edited by jennifer-shehane Loading

Current behavior:

Desired behavior:

How to reproduce:

Additional Info (images, stack traces, etc)

brian-mann commented Oct 18, 2017

Mende commented Nov 3, 2017

brian-mann commented Nov 3, 2017

daniil-g-8sph commented Nov 19, 2017 • edited by jennifer-shehane Loading

TopWebGhost commented Dec 13, 2017

wijwoj commented Dec 18, 2017 • edited by jennifer-shehane Loading

tan-nhu commented Jan 17, 2018

This comment has been minimized.

This comment has been minimized.

shcallaway commented Feb 16, 2018 • edited Loading

adrinr commented Feb 16, 2018

dracos commented Mar 26, 2018

rafaelchiti commented Mar 27, 2018 • edited Loading

dracos commented Mar 28, 2018

mparpaillon commented Apr 3, 2018

royston-c commented Apr 27, 2018

rafaelchiti commented Apr 27, 2018

StormPooper commented May 25, 2018

pperry-atlassian commented May 25, 2018

StormPooper commented May 31, 2018

jechlin commented Jun 8, 2018

amenk commented Dec 6, 2018

mlc-mlapis commented Dec 20, 2018 • edited Loading

jennifer-shehane commented Dec 20, 2018

brian-mann commented Dec 26, 2018

tomaass commented Jan 2, 2019

mlc-mlapis commented Jan 2, 2019

tomaass commented Jan 3, 2019 • edited Loading

mlc-mlapis commented Jan 3, 2019

jennifer-shehane commented Jan 3, 2019

nabby27 commented Dec 5, 2019

jennifer-shehane commented Jan 2, 2020

AshMcConnell commented Oct 18, 2017 •

edited by jennifer-shehane

Loading

daniil-g-8sph commented Nov 19, 2017 •

edited by jennifer-shehane

Loading

wijwoj commented Dec 18, 2017 •

edited by jennifer-shehane

Loading

shcallaway commented Feb 16, 2018 •

edited

Loading

rafaelchiti commented Mar 27, 2018 •

edited

Loading

mlc-mlapis commented Dec 20, 2018 •

edited

Loading

tomaass commented Jan 3, 2019 •

edited

Loading