chore(server): align test folder structure to src folder structure #18597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyrohrbough
requested review from
mjhenkes and
BlueWinds
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
emilyrohrbough
commented
Oct 21, 2021
| @@ -2412,25 +2412,3 @@ describe('lib/config', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('lib/util/config', () => { | |||
There was a problem hiding this comment.
moved to util/config_spec.js test file
emilyrohrbough
commented
Oct 21, 2021
| @@ -5,7 +5,7 @@ const utils = require(`${root}../lib/browsers/utils`) | |||
| const snapshot = require('snap-shot-it') | |||
|
|
|||
| const normalizeBrowsers = (message) => { | |||
| return message.replace(/(found are: ).*/, '$1chrome, firefox, electron') | |||
| return message.replace(/(found on your system are:)((\n.*)*)/, '$1\n- chrome\n- firefox\n- electron') | |||
There was a problem hiding this comment.
fixes this snapshot error which will vary depending on the browsers installed on one's machine:
----------
Difference
----------
Available browsers found on your system are:
- chrome
- firefox
+- edge
- electron
-------------------
Saved snapshot text
-------------------
Can't run because you've entered an invalid browser name.
Browser: 'browserNotGonnaBeFound' was not found on your system or is not supported by Cypress.
Cypress supports the following browsers:
- chrome
- chromium
- edge
- electron
- firefox
You can also use a custom browser: https://on.cypress.io/customize-browsers
Available browsers found on your system are:
- chrome
- firefox
- electron
------------
Current text
------------
Can't run because you've entered an invalid browser name.
Browser: 'browserNotGonnaBeFound' was not found on your system or is not supported by Cypress.
Cypress supports the following browsers:
- chrome
- chromium
- edge
- electron
- firefox
You can also use a custom browser: https://on.cypress.io/customize-browsers
Available browsers found on your system are:
- chrome
- firefox
- edge
- electron
--------
Diff end
--------
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
mjhenkes
approved these changes
Oct 25, 2021
chrisbreiding
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
packages/servermodule:PR Tasks