Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 21316 windows node11 #2699

Merged
merged 54 commits into from
Nov 13, 2018
Merged

Issue 21316 windows node11 #2699

merged 54 commits into from
Nov 13, 2018

Conversation

zerdos
Copy link

@zerdos zerdos commented Oct 31, 2018

Related issue: #2667

nodejs/node#21316

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli/lib/util.js Outdated Show resolved Hide resolved
@aldarund
Copy link

aldarund commented Nov 1, 2018

@zerdos That PR dont fix the issue in the ticket.
As you can see on line 68 of util.js https://github.com/cypress-io/cypress/pull/2699/files#diff-ff7fed4466b74a64c92a94073a299a3dR68 it converts boolean to 0 or 1 string. And then it dont work because of this. If pass false instead of 0 it will work. But it dont work with 0.

@zerdos
Copy link
Author

zerdos commented Nov 2, 2018

@zerdos That PR dont fix the issue in the ticket.
As you can see on line 68 of util.js https://github.com/cypress-io/cypress/pull/2699/files#diff-ff7fed4466b74a64c92a94073a299a3dR68 it converts boolean to 0 or 1 string. And then it dont work because of this. If pass false instead of 0 it will work. But it dont work with 0.

I made a modification and now it should work!

@mikecousins
Copy link

This would be pretty great to get merged. It's killing us right now.

@chrisbreiding chrisbreiding merged commit 54ce93b into cypress-io:develop Nov 13, 2018
@kuceb
Copy link
Contributor

kuceb commented Nov 28, 2018

@aldarund the problem is windowsHide is not a prop of options.env, its a prop of options
https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options

kuceb added a commit that referenced this pull request Nov 28, 2018
@kuceb kuceb mentioned this pull request Nov 28, 2018
brian-mann pushed a commit that referenced this pull request Dec 3, 2018
* Revert "Issue 21316 windows node11 (#2699) (fixes #2667)"

This reverts commit 54ce93b.

* add windowsHide prop

* fix test name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants