Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clear IndexedDB with sessions clearing #27372

Closed
wants to merge 1 commit into from

Conversation

Revadike
Copy link

@Revadike Revadike commented Jul 24, 2023

Additional details

#1208 (comment)

Steps to test

  1. enable test isolation
  2. set indexeddb value
  3. continue to next test
  4. observe its no longer there (it was before this PR)

How has the user experience changed?

Better test isolation

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@cypress
Copy link

cypress bot commented Jul 24, 2023

33 flaky tests on run #49118 ↗︎

0 27952 1349 0 Flakiness 33

Details:

Clear IndexedDB
Project: cypress Commit: 46e21fa55f
Status: Passed Duration: 23:12 💡
Started: Jul 24, 2023 2:15 PM Ended: Jul 24, 2023 2:38 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  e2e/origin/basic_login.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
basic login > visit primary first > logs in with idp redirect Output Video

The first 5 flaky specs are shown, see all 22 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@nagash77
Copy link
Contributor

@Revadike please read over the contribution guide and fill out the PR template in it's entirety.

@nagash77 nagash77 self-assigned this Jul 24, 2023
@Revadike
Copy link
Author

@Revadike please read over the contribution guide and fill out the PR template in it's entirety.

Done, my intention was to keep discussion within the issue, rather than here.

@nagash77 nagash77 assigned astone123 and unassigned nagash77 Jul 27, 2023
@jennifer-shehane jennifer-shehane added the type: feature New feature that does not currently exist label Jan 19, 2024
@jennifer-shehane jennifer-shehane changed the title Clear IndexedDB feat: Clear IndexedDB with sessions clearing Jan 19, 2024
@jennifer-shehane
Copy link
Member

@Revadike We're going to close this PR at the moment. We don't have time to dedicate to new feature reviews outside of what we've already prioritized unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature that does not currently exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants