fix: try to only add commonjs when running Cypress config

[lmiller1990]

• Closes Next.js + TS not working out of the box #27448 (maybe)
• Closes Unable to compile TypeScript with "moduleResolution": "bundler" option in v5 #26308 (maybe)

Additional details

We hard code module: commonjs. I think it is because we want commonjs to be the default when executing the cypress.config child process.

Hard coding this causes issues when users have projects using the new module: bundler config option in tsconfig.json. I found out we can just still hard code it, but we need to do it a different place, so it is only used when executing the cypress.config child process.

Steps to test

You could verify that the issues this claims to fix are fixed. One way would be adding Cypress in a project with module: bundler in the tsconfig.json, such as the one provided here. #26308

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress]

19 flaky tests on run #50149 ↗︎

0

10407

1022

0

19

Details:

Merge branch 'develop' into lmiller/move-commonjs-module-hard-code
Project: cypress	Commit: 06391eee3a
Status: Passed	Duration: 17:19 💡
Started: Aug 18, 2023 6:53 PM	Ended: Aug 18, 2023 7:10 PM

  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test		Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse		Output Video

  e2e/origin/dependencies.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test		Artifacts
cy.origin dependencies > works		Output Video

  e2e/origin/commands/querying.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test		Artifacts
cy.origin querying > .get()		Output Video

  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test		Artifacts
cy.origin assertions > .should() and .and()		Output Video

  e2e/origin/basic_login.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test		Artifacts
basic login > visit primary first > logs in with idp redirect		Output Video

The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[jordanpowell88]

Is this working for you @lmiller1990. I'm still running into the issue running this code locally.

[lmiller1990]

Not sure, I didn't get a chance to test it thoroughly. Did your commit fix it @jordanpowell88 ?

Does it fix #27448?

Not really ideal, apps with bundler will still be bundled slightly differently, but this at least unblocks latest next.js.

[jordanpowell88]

Not sure, I didn't get a chance to test it thoroughly. Did your commit fix it @jordanpowell88 ?

Does it fix #27448?

Not really ideal, apps with bundler will still be bundled slightly differently, but this at least unblocks latest next.js.

I agree but this does appear to fix the issue. Not sure if their is a better solution

[lmiller1990]

@AtofStryker can you please take another look? Thanks!

[cypress-bot]

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.