Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode urls in prerequest #28427

Merged
merged 3 commits into from
Nov 29, 2023
Merged

fix: decode urls in prerequest #28427

merged 3 commits into from
Nov 29, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Nov 29, 2023

Additional details

When correlating prerequests, it's possible one of them will be decoded and the other will not. This will lead to an unnecessary correlation timeout of two seconds.

This occurs because we use the legacy url API while CDP uses the WHATWG URL standard. #28369 has been logged to update the codebase to the WHATWG URL API.

However, in the meantime, we are decoding all prerequests as they come in so the correlations will be correct.

The following requests were observed in the wild:

With the encoded | as %7C:
https://fonts.googleapis.com/css?family=Roboto+Mono%7COpen+Sans:700&display=swap

Already decoded |:
https://fonts.googleapis.com/css?family=Roboto+Mono|Open+Sans:700&display=swap

Steps to test

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Nov 29, 2023

4 flaky tests on run #52601 ↗︎

0 6062 77 0 Flakiness 4

Details:

adding server integration tests
Project: cypress Commit: def0e214d4
Status: Passed Duration: 14:16 💡
Started: Nov 29, 2023 7:18 PM Ended: Nov 29, 2023 7:32 PM
Flakiness  e2e/origin/snapshots.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin - snapshots > e2e log verification > Does not take snapshots of XHR/fetch requests from secondary origin if the wrong origin is visited / origin mismatch, but instead the primary origin (existing behavior) Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay

Review all test suite changes for PR #28427 ↗︎

@mschile mschile merged commit 57bb0b6 into develop Nov 29, 2023
82 of 84 checks passed
@mschile mschile deleted the mschile/prerequest_decode branch November 29, 2023 22:09
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 5, 2023

Released in 13.6.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants