-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade electron to 32.2.0 #30394
Conversation
cypress Run #57967
Run Properties:
|
Project |
cypress
|
Branch Review |
ryanm/chore/electron-upgrade
|
Run status |
Passed #57967
|
Run duration | 17m 05s |
Commit |
32ea2510e5: Merge branch 'release/14.0.0' into ryanm/chore/electron-upgrade
|
Committer | Ryan Manuel |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
26
|
Skipped |
0
|
Passing |
770
|
View all changes introduced in this branch ↗︎ |
UI Coverage
67.07%
|
|
---|---|
Untested elements |
25
|
Tested elements |
55
|
Accessibility
96.17%
|
|
---|---|
Failed rules |
0 critical
4 serious
1 moderate
0 minor
|
Failed elements |
203
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanthemanuel I believe we can remove this line of code: https://github.com/cypress-io/cypress/blob/develop/cli/lib/exec/spawn.js#L46 since this was fixed here: electron/electron#35961
@jennifer-shehane updated here: |
Co-authored-by: Matt Schile <[email protected]>
Additional details
There are several things to call out in this upgrade:
better-sqlite3
vianode-gyp
requires gcc-10 and g++-10 now due to this patch in electron which necessitated these changes:mock-fs
to fix various unit teststs-node
to get around an issue with serializing errorswin.webContents
crash
events torender-process-gone
evil-dns
to handle a node 20 issueSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?