Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove the cypress/angular-signals test harness. The changes incorporated in @cypress/angular-signals are now merged upstream into @cypress/angular and the package is no longer needed #30540

Merged

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Nov 4, 2024

Additional details

merges the angular-signals test harness implemented in #29621 upstream into cypress/angular and deleted the angular-signals test harness as we no longer need it.

  • how does migration look like?
    When starting Cypress 14, and a user is pulling in cypress/angular-signals, an error is thrown as we no longer ship this with the binary. This is covered in the migration guide
Screenshot 2024-11-07 at 9 06 01 AM

changing the import from cypress/angular-signals to cypress/angular works as expected and signals is natively supported in cypress/angular
Screenshot 2024-11-07 at 9 07 07 AM

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker self-assigned this Nov 4, 2024
@AtofStryker AtofStryker added type: breaking change Requires a new major release version npm: @cypress/angular @cypress/angular package issues Cypress 14 Issues scoped for Cypress 14 labels Nov 4, 2024
@AtofStryker AtofStryker force-pushed the breaking/remove_angular_signals_test_harness branch from c01a361 to 6c3286c Compare November 4, 2024 21:15
Copy link

cypress bot commented Nov 4, 2024

cypress    Run #58223

Run Properties:  status check passed Passed #58223  •  git commit ddd40669a2: breaking: remove the cypress/angular-signals test harness. The changes incorpora...
Project cypress
Branch Review breaking/remove_angular_signals_test_harness
Run status status check passed Passed #58223
Run duration 17m 34s
Commit git commit ddd40669a2: breaking: remove the cypress/angular-signals test harness. The changes incorpora...
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 27
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 765
View all changes introduced in this branch ↗︎
UI Coverage  68.29%
  Untested elements 24  
  Tested elements 56  
Accessibility  96.21%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 202  

@AtofStryker AtofStryker force-pushed the breaking/remove_angular_under_17_2 branch 7 times, most recently from 75ad733 to abd9411 Compare November 5, 2024 12:45
@AtofStryker AtofStryker force-pushed the breaking/remove_angular_signals_test_harness branch from 6c3286c to 0b43713 Compare November 5, 2024 12:47
@AtofStryker AtofStryker linked an issue Nov 5, 2024 that may be closed by this pull request
@AtofStryker AtofStryker force-pushed the breaking/remove_angular_under_17_2 branch from abd9411 to a6c2708 Compare November 5, 2024 19:44
@AtofStryker AtofStryker force-pushed the breaking/remove_angular_signals_test_harness branch from 0b43713 to 9902525 Compare November 5, 2024 19:46
@AtofStryker AtofStryker force-pushed the breaking/remove_angular_under_17_2 branch from a6c2708 to 74f853b Compare November 6, 2024 19:06
Base automatically changed from breaking/remove_angular_under_17_2 to release/14.0.0 November 6, 2024 20:06
@AtofStryker AtofStryker force-pushed the breaking/remove_angular_signals_test_harness branch from 9902525 to d434834 Compare November 6, 2024 20:10
…s incorporated in @cypress/angular-signals are now merged upstream into @cypress/angular and the package is no longer needed [run ci]
@AtofStryker AtofStryker force-pushed the breaking/remove_angular_signals_test_harness branch from d434834 to ddd4066 Compare November 6, 2024 23:17
@AtofStryker AtofStryker marked this pull request as ready for review November 7, 2024 14:16
@AtofStryker AtofStryker merged commit edd9a27 into release/14.0.0 Nov 7, 2024
136 of 137 checks passed
@AtofStryker AtofStryker deleted the breaking/remove_angular_signals_test_harness branch November 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cypress 14 Issues scoped for Cypress 14 npm: @cypress/angular @cypress/angular package issues type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support angular signals inside cypress/angular
2 participants