-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch request
, request-promise
to @cypress/
forks
#6777
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
request
, request-promise
to @cypress/
forksrequest
, request-promise
to @cypress/
forks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Could this be released, please? |
This will be fixed in our next release which is scheduled for Monday. In the meantime, install Cypress 4.1.0 which does not have this issue. |
User facing changelog
cypress
installation could fail if Git is not installed.Additional details
request
, not@cypress/request
yarn why request
to see why some instances ofrequest
are still in. mostly dev dependencies.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?