Fix test script, add Mocha result checks to internal Cypress te… #7110

flotwig · 2020-04-22T15:52:14Z

Additional details

fixes cypress.js test script so it will exit with a non-zero exit code if an error occurs
adds cypress-multi-reporters to desktop-gui and driver and reporter and ui-components so they output a junit xml report
adds verify-mocha-results test stage to those cypress tests

cypress-bot · 2020-04-22T15:52:16Z

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

The feature/bugfix is self-documenting from within the product.
The change provides the end user with a way to fix their problem (no dead ends).

Functionality

The code works and performs its intended function with the correct logic.
Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

The code is readable (too many nested 'if's are a bad sign).
Names used for variables, methods, etc, clearly describe their function.
The code is easy to understood and there are relevant comments explaining.
New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
There are comments containing link(s) to the addressed issue (in tests and code).

Quality

The change does not reimplement code.
There's not a module from the ecosystem that should be used instead.
There is no redundant or duplicate code.
There are no irrelevant comments left in the code.
Tests are testing the code’s intended functionality in the best way possible.

Internal

The original issue has been tagged with a release in ZenHub.

cypress · 2020-04-22T16:18:45Z

Test summary

7182 • 0 • 98 • 0

Run details


Project	cypress
Status	Passed
Commit	`05e5927`
Started	Apr 23, 2020 2:43 PM
Ended	Apr 23, 2020 2:49 PM
Duration	05:44 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

bahmutov · 2020-04-23T16:19:36Z

circle.yml

+          command: |
+            CYPRESS_KONFIG_ENV=production \
+            CYPRESS_RECORD_KEY=$PACKAGES_RECORD_KEY \
+            yarn cypress:run --record --parallel --group 5x-driver-<< parameters.browser >> --browser << parameters.browser >>


i feel like this one would be a good Circle command to factor out

bahmutov · 2020-04-23T16:20:18Z

circle.yml


  # "driver-integration-tests-electron":
  #   <<: *defaults
  #   parallelism: 5
  #   steps:
-  #     - attach_workspace:


I like how you removed commented out code too :) and inserted commented out NEW code

gotta keep those comments up to date!

bahmutov · 2020-04-23T16:20:56Z

circle.yml

@@ -619,7 +601,9 @@ jobs:
          command: |
            CYPRESS_KONFIG_ENV=production \
            CYPRESS_RECORD_KEY=$PACKAGES_RECORD_KEY \
-            yarn lerna exec --scope @packages/desktop-gui "yarn cypress:run --record --parallel --group 2x-desktop-gui"
+            yarn cypress:run --record --parallel --group 2x-desktop-gui


sweet change

bahmutov · 2020-04-23T16:22:09Z

packages/desktop-gui/cypress.json

@@ -2,5 +2,9 @@
  "baseUrl": "http://localhost:5005",
  "projectId": "ypt4pf",
  "viewportWidth": 800,
-  "viewportHeight": 850
+  "viewportHeight": 850,
+  "reporter": "../../node_modules/cypress-multi-reporters/index.js",


are you pointing at the cypress-multi-reporters at the root, then why add them to each package?

it makes intuitive sense for them to be installed per-package, but yarn hoists them, and cypress won't load it by name if it's hoisted outside the current directory (#4536). so it was really just a choice, it could also be installed in the root package

bahmutov

I like it, just had a question about cypress-multi-reporter in each package

flotwig added 3 commits April 22, 2020 11:16

fix cypress.js script typo

850b093

add verify-mocha-results to driver integration test stages

e567073

add cypress-multi-reporters

79eb365

flotwig added 3 commits April 22, 2020 11:53

fix circle.yml

1566f25

fix yarn.lock

69e6bc3

cleanup

c44c237

flotwig added 6 commits April 22, 2020 12:22

use working_directory instead of yarn workspace commands

84bb246

add reports to ui-components and reporter, update circle.yml

c2e92fe

fix circle.yml

13a3ed1

fix circle.yml

958e4ec

fix circle.yml

4ec5738

add more verify-mocha-results

05e5927

flotwig marked this pull request as ready for review April 23, 2020 15:33

flotwig requested review from chrisbreiding and bahmutov April 23, 2020 16:17

bahmutov reviewed Apr 23, 2020

View reviewed changes

bahmutov approved these changes Apr 23, 2020

View reviewed changes

flotwig changed the title ~~Fix test script, add Mocha result checks to internal Cypress tests~~ Fix test script, add Mocha result checks to internal Cypress te… Apr 23, 2020

flotwig merged commit c80e482 into develop Apr 23, 2020

cypress-bot bot mentioned this pull request Apr 23, 2020

CircleCI exits as passing when Cypress tests have failed in our development #7052

Closed

flotwig deleted the issue-7052-2 branch January 24, 2022 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix test script, add Mocha result checks to internal Cypress te… #7110

Fix test script, add Mocha result checks to internal Cypress te… #7110

flotwig commented Apr 22, 2020 •

edited

Loading

cypress-bot bot commented Apr 22, 2020

cypress bot commented Apr 22, 2020 •

edited

Loading

bahmutov Apr 23, 2020

bahmutov Apr 23, 2020

flotwig Apr 23, 2020

bahmutov Apr 23, 2020

bahmutov Apr 23, 2020

flotwig Apr 23, 2020

bahmutov left a comment

Fix test script, add Mocha result checks to internal Cypress te… #7110

Fix test script, add Mocha result checks to internal Cypress te… #7110

Conversation

flotwig commented Apr 22, 2020 • edited Loading

Additional details

cypress-bot bot commented Apr 22, 2020

PR Review Checklist

User Experience

Functionality

Maintainability

Quality

Internal

cypress bot commented Apr 22, 2020 • edited Loading

Test summary

Run details

bahmutov Apr 23, 2020

Choose a reason for hiding this comment

bahmutov Apr 23, 2020

Choose a reason for hiding this comment

flotwig Apr 23, 2020

Choose a reason for hiding this comment

bahmutov Apr 23, 2020

Choose a reason for hiding this comment

bahmutov Apr 23, 2020

Choose a reason for hiding this comment

flotwig Apr 23, 2020

Choose a reason for hiding this comment

bahmutov left a comment

Choose a reason for hiding this comment

flotwig commented Apr 22, 2020 •

edited

Loading

cypress bot commented Apr 22, 2020 •

edited

Loading