-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test script, add Mocha result checks to internal Cypress te… #7110
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
command: | | ||
CYPRESS_KONFIG_ENV=production \ | ||
CYPRESS_RECORD_KEY=$PACKAGES_RECORD_KEY \ | ||
yarn cypress:run --record --parallel --group 5x-driver-<< parameters.browser >> --browser << parameters.browser >> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel like this one would be a good Circle command to factor out
|
||
# "driver-integration-tests-electron": | ||
# <<: *defaults | ||
# parallelism: 5 | ||
# steps: | ||
# - attach_workspace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you removed commented out code too :) and inserted commented out NEW code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta keep those comments up to date!
@@ -619,7 +601,9 @@ jobs: | |||
command: | | |||
CYPRESS_KONFIG_ENV=production \ | |||
CYPRESS_RECORD_KEY=$PACKAGES_RECORD_KEY \ | |||
yarn lerna exec --scope @packages/desktop-gui "yarn cypress:run --record --parallel --group 2x-desktop-gui" | |||
yarn cypress:run --record --parallel --group 2x-desktop-gui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet change
@@ -2,5 +2,9 @@ | |||
"baseUrl": "http://localhost:5005", | |||
"projectId": "ypt4pf", | |||
"viewportWidth": 800, | |||
"viewportHeight": 850 | |||
"viewportHeight": 850, | |||
"reporter": "../../node_modules/cypress-multi-reporters/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you pointing at the cypress-multi-reporters at the root, then why add them to each package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it makes intuitive sense for them to be installed per-package, but yarn hoists them, and cypress won't load it by name if it's hoisted outside the current directory (#4536). so it was really just a choice, it could also be installed in the root package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, just had a question about cypress-multi-reporter in each package
Closes #7052
Additional details