Add UTM parameters to Dashboard login buttons

[panzarino]

• Closes Add UTM parameters to Dashboard login buttons [TR-37] #7638

Additional details

Adds tracking to dashboard login links

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

7655 • 0 • 119 • 0

---

Run details

Project	cypress
Status	Passed
Commit	6f44bce
Started	Jun 19, 2020 8:09 PM
Ended	Jun 19, 2020 8:16 PM
Duration	07:29 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

We should probably add a test here, since we're not technically testing that this link in the project setup modal is correctly routing to the dashboard route.

https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/cypress/integration/setup_project_modal_spec.js#L522:L522

[panzarino]

@jennifer-shehane Turns out I was putting the UTM parameters on the wrong links, I've updated it now.

I'm fairly unfamiliar as to how to write a full e2e test that will check for full functionality here as these changes span both desktop-gui and server. I'm also unsure of whether Google Analytics will actually pick up on the UTM parameters when sent through this method, so essentially there needs to be additional testing all around.

[flotwig]

I'm fairly unfamiliar as to how to write a full e2e test that will check for full functionality here as these changes span both desktop-gui and server. I'm also unsure of whether Google Analytics will actually pick up on the UTM parameters when sent through this method, so essentially there needs to be additional testing all around.

@panzarino I don't think you need a full e2e test for this. Probably just a Cypress test in desktop-gui that verifies that the UTM code is sent to the IPC channel, and then a unit test in the server auth_spec that verifies that the expected URL is generated. You could also add a test in events_spec that the IPC event calls beginAuth properly.

[flotwig]

nice!