Skip to content

Commit

Permalink
test: fix version on wait-on for react-scripts (#820)
Browse files Browse the repository at this point in the history
Increase timeout to 60 seconds
Update README example to 60 seconds
  • Loading branch information
MikeMcC399 authored Mar 16, 2023
1 parent 249883b commit b09d393
Show file tree
Hide file tree
Showing 6 changed files with 393 additions and 32 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/example-wait-on.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ jobs:
working-directory: examples/v9/react-scripts
start: npm start
# let's use wait-on NPM package to check the URL
wait-on: 'npx wait-on --timeout 5000 http://127.0.0.1:3000'
wait-on: 'npx wait-on --timeout 60000 http://127.0.0.1:3000'

ping-cli-v9:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -330,7 +330,7 @@ jobs:
working-directory: examples/react-scripts
start: npm start
# let's use wait-on NPM package to check the URL
wait-on: 'npx wait-on --timeout 5000 http://127.0.0.1:3000'
wait-on: 'npx wait-on --timeout 60000 http://127.0.0.1:3000'

ping-cli:
runs-on: ubuntu-22.04
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,7 @@ You can even use your own command (usually by using `npm`, `yarn`, `npx`) to wai
- uses: cypress-io/github-action@v5
with:
start: npm start
wait-on: 'npx wait-on --timeout 5000 http://localhost:3000'
wait-on: 'npx wait-on --timeout 60000 http://localhost:3000'
```

See [example-wait-on.yml](.github/workflows/example-wait-on.yml) workflow file.
Expand Down
233 changes: 207 additions & 26 deletions examples/react-scripts/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion examples/react-scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"cypress": "12.8.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-scripts": "^5.0.1"
"react-scripts": "^5.0.1",
"wait-on": "^7.0.1"
},
"browserslist": {
"production": [
Expand Down
Loading

0 comments on commit b09d393

Please sign in to comment.