Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove pnpm store caching #1188

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

Workflows such as .github/workflows/example-basic-pnpm.yml, which attempt to cache the contents of the pnpm store, fail sporadically, especially after there has been a change in the version of Cypress and where pnpm workflow jobs are running in parallel.

If the cache of the pnpm store cache is loaded with the cypress module, through steps outside of the Cypress GitHub action, and the Cypress binary has not been successfully cached by the action, then Cypress fails with a verification error.

There is no mechanism available to coordinate these two different caching mechanisms. (See also #1179 (comment) for further explanation.)

Change

pnpm store caching is removed from the documentation:

README > pnpm

and replaced by text which recommends against this caching.

The following workflows are amended accordingly:

Related

@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Collaborator Author

Force pushed with no changes to test caching on subsequent runs. Test was successful.

@jennifer-shehane jennifer-shehane merged commit d1971e9 into cypress-io:master May 27, 2024
75 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/pnpm-store-caching branch May 27, 2024 12:20
Copy link

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sporadic cypress binary cache failure of example-basic-pnpm workflow on Ubuntu
3 participants