Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the README > Docker image example:
It builds on the suggestions made in the open PRs docs: adding in information on running firefox in a container in the README #938 and Update README.md to include user option #963 to add
options: --user 1001
to the Docker example. For GitHub-hosted runners--user 1001
is mandatory when testing against Mozilla Firefox and optional for other browsers.The container is changed to the generic
cypress/browsers:latest
image tag to provide a timeless and easily readable example. A link to the Docker Hub cypress/browsers:latest is provided so that readers can search for specific versions such as cypress/browsers:node-20.5.0-chrome-114.0.5735.133-1-ff-114.0.2-edge-114.0.1823.51-1The example is linked to the cypress-io/cypress-docker-images repo for further information. A pointer to cypress-io/cypress-docker-images > factory is given for users who want to generate containers for specific versions.
Verification
The Workflow below demonstrates the example using the four supported browsers
chrome
,edge
,electron
&firefox
on a GitHub-hosted runner, with successful results logged to run 5866097433.