Skip to content

Commit

Permalink
Move to keyset pagination (#220)
Browse files Browse the repository at this point in the history
* move to keyset pagination

* linting

* adjustments for further data integration

* test adjustments

* linting corrections

* run dev workflow

* fix docs

* remove custom sql join for large data test

* test with rowcount update

* linting, docs, cleanup

* cleanup

* remove test branch

* rework pageset generation

* linting

* fix types and docstring

Co-Authored-By: Faisal Alquaddoomi <[email protected]>

* docs and types

* update to use pageset instead of chunk fxn names

Co-Authored-By: Jenna Tomkinson <[email protected]>

* update variable names

Co-Authored-By: Gregory Way <[email protected]>

* better exception docs

* better docstring parameter description

Co-Authored-By: Gregory Way <[email protected]>

* better documentation and exception msg

* remove exception

* point to the example in docs

Co-Authored-By: Gregory Way <[email protected]>

* add further notes about when/why to customize

* linting

* remove test raise

* sorted results from concatenation by natural sort

---------

Co-authored-by: Faisal Alquaddoomi <[email protected]>
Co-authored-by: Jenna Tomkinson <[email protected]>
Co-authored-by: Gregory Way <[email protected]>
  • Loading branch information
4 people committed Aug 26, 2024
1 parent 7c191ec commit 81584ba
Show file tree
Hide file tree
Showing 10 changed files with 477 additions and 282 deletions.
7 changes: 0 additions & 7 deletions cytotable/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,6 @@
],
}

# metadata column names and types for internal use within CytoTable
CYOTABLE_META_COLUMN_TYPES = {
"cytotable_meta_source_path": "VARCHAR",
"cytotable_meta_offset": "BIGINT",
"cytotable_meta_rownum": "BIGINT",
}

CYTOTABLE_DEFAULT_PARQUET_METADATA = {
"data-producer": "https://github.com/cytomining/CytoTable",
"data-producer-version": str(_get_cytotable_version()),
Expand Down
Loading

0 comments on commit 81584ba

Please sign in to comment.