Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weekly testing for preventative awareness of external changes #167

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Mar 14, 2024

Description

This PR adds a weekly check occurring at 7 AM UTC on Wednesdays to help detect external changes that could effect CytoTable (such as dependency updates). This change comes as a result of the issues in #163, which were discovered by @shntnu in the process of attempting to use CytoTable. Generally, I expect this to happen again with other dependencies over time (I believe we've also encountered similar issues with Parsl, for example), so this is an attempt to add a simple solution towards prevention. After this change completes, my hope would be that we might have early awareness of these types of issues in the future such that users don't have as much burden to troubleshoot.

References #163

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@d33bs
Copy link
Member Author

d33bs commented Mar 15, 2024

Thank you @gwaybio ! Merging this in.

@d33bs d33bs merged commit ce8b1cc into cytomining:main Mar 15, 2024
7 checks passed
@d33bs d33bs deleted the weekly-test-checks branch March 15, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants