Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use declarative version specification for Ubuntu GitHub Actions runners #199

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Apr 25, 2024

Description

This PR addresses #197 by setting a specific version for Ubuntu runners through GitHub Actions. It follows thoughts from #195 where we experienced surprising issues after macos-latest began referencing versions which aren't compatible with Python versions we remain compatible with here.

Thank you for any thoughts or feedback you may have!

Closes #197

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs
Copy link
Member Author

d33bs commented Apr 26, 2024

Thanks @kenibrewer ! Merging this in.

@d33bs d33bs merged commit 2f9e6e8 into cytomining:main Apr 26, 2024
11 checks passed
@d33bs d33bs deleted the gh-actions-ubuntu-image-distinction branch April 26, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ubuntu-latest to specific version for GH Actions os specifications
2 participants