Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding epsilon parameter to spherize #132

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Mar 17, 2021

closes #128

Note that I do not test this addition. I added a note to #127 that we need to also test epsilon's effect when we address this more fully.

@gwaybio
Copy link
Member Author

gwaybio commented Mar 17, 2021

@shntnu - do you want to take a look? It is a simple PR, but we might want to continue our pull request review culture.

Returns
-------
pd.DataFrame or None
The normalized profile DataFrame. If ouput_file="none", then return the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ouput_file

@gwaybio
Copy link
Member Author

gwaybio commented Mar 19, 2021

I added a rudimentary test in 835fcc9, primarily to ensure that epsilon is successfully passed as a variable through normalize.py to Spherize(). Going to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add epsilon as an option in normalize
2 participants