Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(runners): update macos version for python #408

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Apr 23, 2024

Description

This PR addresses #406 by pinning the MacOS GitHub Actions runner to macos-13. Without this change, we will see issues from Python 3.8 and 3.9 installations through the macos-latest (version 14) runner images.

Closes #406

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenibrewer kenibrewer merged commit c4301e1 into cytomining:main Apr 24, 2024
11 checks passed
@kenibrewer
Copy link
Member

Merged because we're already seeing failed jobs due to this error. Thanks for finding this @d33bs

@kenibrewer
Copy link
Member

@d33bs Just a note that I had to clear the github actions cache to get the mac-os - python3.11 job to pass. gh cache delete --all -R cytomining/pycytominer is a pretty useful command for troubleshooting actions stuff that might be cache related.

@d33bs
Copy link
Member Author

d33bs commented Apr 24, 2024

Thanks @kenibrewer for the review, merge, and tip on the cache!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve MacOS Python setup issues within GitHub Actions runner images after recent update
2 participants