Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge label projections should not be redundantly calculated #2327

Closed
maxkfranz opened this issue Mar 5, 2019 · 0 comments
Closed

Edge label projections should not be redundantly calculated #2327

maxkfranz opened this issue Mar 5, 2019 · 0 comments
Assignees
@maxkfranz
Labels
performance Improving speed and memory usage
Milestone
3.5.0

Comments

@maxkfranz
Copy link
Member

Issue type

Feature request

Description of new feature

The call to recalculateEdgeLabelProjections() within recalculateRenderedStyle() is redundant. The control point calculation code already handles it.

Motivation for new feature

Performance
@maxkfranz maxkfranz added the performance Improving speed and memory usage label Mar 5, 2019
@maxkfranz maxkfranz added this to the 3.5.0 milestone Mar 5, 2019
@maxkfranz maxkfranz self-assigned this Mar 5, 2019
maxkfranz added a commit that referenced this issue Mar 5, 2019
@maxkfranz
Edge label projections should not be redundantly calculated #2327
75f7078 
The control point code already calls `recalculateEdgeLabelProjections()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxkfranz maxkfranz

Labels
performance Improving speed and memory usage
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
1 participant
@maxkfranz