Use IRODS specific XML dialect #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterverraedt
force-pushed
the
use-irods-xml-dialect
branch
4 times, most recently
from
3f82f86
to
17703bf
Compare
|
Thank you for the fix. |
Signed-off-by: Peter Verraedt <[email protected]>
peterverraedt
force-pushed
the
use-irods-xml-dialect
branch
from
17703bf
to
c312ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRODS uses its own dialect for XML communication. Stumbled on this because the AddUser-function did not accept passwords, as the generated scrambled password contained the quote character
". Xml.Marshal encodes this as", but the irods server only looks for",',<,>and&to replace these back to the original characters and leaves"as is.While investigating it, I noticed that before 4.2.9 also
'was corresponding to the`character instead of'. As a result, if one uploads a file with the icommands with the nametest'`.txt, the go library would seetest''.txt.I've added XML pre- and processing functions, so that xml.Marshal XML is translated back and forwards to XML irods can understand. I do it in the Request function, and not in the individual
GetBytes()/FromBytes()functions as I was first planning to, as I need to do different translations depending on the server version of irods.Signed-off-by: Peter Verraedt [email protected]