Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refreshing for debug #61

Merged
merged 4 commits into from
Dec 20, 2022
Merged

refreshing for debug #61

merged 4 commits into from
Dec 20, 2022

Conversation

d-a-v
Copy link
Owner

@d-a-v d-a-v commented Jul 28, 2022

  • Removed old buffered debug-print
  • Due to newlib update for esp8266-Arduino, use printf instead of os_printf

@mcspr

This comment was marked as outdated.

Sign in to view
@mcspr

This comment was marked as outdated.

Sign in to view
mcspr
mcspr reviewed Aug 4, 2022
View reviewed changes
glue/gluedebug.h Outdated Show resolved Hide resolved
@mcspr mcspr merged commit 8e3c4ee into master Dec 20, 2022
@mcspr
Copy link
Collaborator

mcspr commented Dec 20, 2022

I may be misremembering the whole set of issues... Wasn't there also some kind of problem with the #include order?
Meaning, lwip cc and etc .h set a lot of stuff for glue to build in lwip1.4 compatible mode. But, is it generally safe to keep those things in exported headers?

@d-a-v
Copy link
Owner Author

d-a-v commented Dec 20, 2022

The purpose has always been to unexpose lwip1.4 to upper layers (Arduino).
The lwip1.4 side is only useful to link with and talk to nonosdk libs.
This PR intention is to cleanup unused file (I had made them because I was not aware that my usbserial chip was unable to to use 74880 back then)

@d-a-v d-a-v deleted the refreshing branch December 20, 2022 14:36
mcspr pushed a commit to esp8266/Arduino that referenced this pull request Dec 21, 2022
@d-a-v
lwip2: cleanup logging and use newlib printf (#8769)
edfde6b 
d-a-v/esp82xx-nonos-linklayer#61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcspr mcspr mcspr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-a-v @mcspr