Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dala 1189 ktlint latest version #175

Merged
merged 20 commits into from
Feb 8, 2023
Merged

Conversation

emanueldfine
Copy link
Contributor

@emanueldfine emanueldfine commented Feb 7, 2023

Pull Request <Title>

ktlint issue was fixed: JLLeitschuh/ktlint-gradle#589
=> updated gradle plugin and ktlintVersion to the latest version

Things to do during Peer Review

Please check all boxes before the Pull Request is merged. In case you skip a box, describe in the PRs description (that means: here) why the check is skipped.

  • The Github Actions (including Sonarqube Gateway and Lint Checks) are green. This is enforced by Github.
  • A peer-review has been executed
    • The code has been manually inspected by someone who did not implement the feature
  • The PR actually implements what is described in the JIRA-Issue
  • At least one E2E Test exists testing the new feature
  • Documentation is updated as required
  • The automated deployment is updated if required
  • The new version is deployed to the dev server "dev1" using this branch
    • It's verified that this version actually is the one deployed (check gitinfo for branch name and commit id!)
    • The new feature is manually used/tested/observed on dev server
    • All implemented Social Logins have been tested manually in the UI
  • If any work on the UI is to be merged, those changes were also documented in the Figma

@emanueldfine emanueldfine marked this pull request as ready for review February 7, 2023 10:19
@ppuetsch ppuetsch temporarily deployed to development February 7, 2023 10:37 — with GitHub Actions Inactive
@ppuetsch ppuetsch temporarily deployed to development February 7, 2023 10:43 — with GitHub Actions Inactive
@ppuetsch ppuetsch temporarily deployed to development February 7, 2023 10:43 — with GitHub Actions Inactive
@ppuetsch ppuetsch temporarily deployed to development February 7, 2023 10:43 — with GitHub Actions Inactive
@ppuetsch ppuetsch temporarily deployed to development February 7, 2023 10:43 — with GitHub Actions Inactive
@ppuetsch ppuetsch self-requested a review February 7, 2023 10:47
@ppuetsch ppuetsch self-assigned this Feb 7, 2023
@ppuetsch ppuetsch temporarily deployed to development February 8, 2023 09:06 — with GitHub Actions Inactive
@ppuetsch ppuetsch temporarily deployed to development February 8, 2023 09:11 — with GitHub Actions Inactive
@ppuetsch ppuetsch temporarily deployed to development February 8, 2023 09:11 — with GitHub Actions Inactive
@ppuetsch ppuetsch temporarily deployed to development February 8, 2023 09:12 — with GitHub Actions Inactive
@ppuetsch ppuetsch temporarily deployed to development February 8, 2023 09:12 — with GitHub Actions Inactive
@ppuetsch ppuetsch merged commit 0770ba1 into main Feb 8, 2023
@ppuetsch ppuetsch deleted the DALA-1189_ktlint_latest_version branch February 10, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin does not work when using Ktlint 0.46.0
2 participants