This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Default to using the number of brokers we create. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the operator creates a 3 node cluster, but default replication factor is currently set to 1, ie no replication at all. This creates a dangerous footgun, where creating a default cluster can give the impression that having multiple brokers means there is some protection from hardware failure, where there is none. A safer default is to match the number of brokers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the operator creates a 3 node cluster, but default replication factor is currently set to 1, ie no replication at all.
This creates a dangerous situation where creating a cluster with the defaults can give the impression that having multiple brokers means there is some protection from hardware failure, where there is none.
A safer default is to match the number of brokers.