Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening certain images (maybe due to image size? file size?) the mouse arrow stays as the loading circle #485

Closed
2 tasks done
Stealth3 opened this issue Jan 4, 2019 · 5 comments

Comments

@Stealth3
Copy link

Stealth3 commented Jan 4, 2019

Prerequisites

  • I have written a descriptive issue title
  • I have searched open and closed issues to ensure it has not already been reported

System information:

  • Windows OS version: Win10
  • ImageGlass version: 6.0.12.29

To Reproduce

Steps to reproduce the behavior:

  1. Open an image

Actual behavior:

Most images load fine
Certain images (not sure what the criteria is) load fine but the mouse cursor stays as the loading circle

Expected behavior:

Cursor should revert back to pointer when image loads

Screenshots:

I tried adding a screen shot but even using the print screen button doesn't include my mouse cursor in a screen shot :(

Additional context:

@AnotherDimension-Ex
Copy link

AnotherDimension-Ex commented Jan 4, 2019

Yes, you are right, I noticed this also with some heavy images.
I think this because when the app is loading image data will be busy and change the cursor, and for some reason still busy even after load image data.

picMain.Cursor = _isAppBusy ? Cursors.WaitCursor : Cursors.Default;

I think using "Cursors.WaitCursor" is needless, and at less for me it still busy a lot of times with no reason.

Also, the loading message, it became a little bit annoying, because when navigate fast with some heavy images, it still displays after the image complete loading for a quiet time (e.g. 5-10 Sec).
This happens sometimes.

I would request an option to disable the loading message.
An option in the setting would be nice.

Thanks!

@ikonomov
Copy link

ikonomov commented Feb 3, 2019

I agree, both the loading circle and loading message are unnecessary, and instead of conveying any useful information they can be annoying when loading large size files.

@fire-eggs
Copy link
Collaborator

OK, I've seen this myself, I'll dig into it further.

@fire-eggs
Copy link
Collaborator

I've identified both a problem and a possible race condition with the 'Loading' message and busy cursor display. I'll be testing my changes to see if the problem continues.

The 'Loading' message is only supposed to appear if loading a given image takes longer than 2 seconds.
I can understand the desire to turn it off if it gets 'stuck'.

@d2phap
Copy link
Owner

d2phap commented Feb 26, 2019

Uploaded IG Moon 6.1
https://imageglass.org/moon

@d2phap d2phap added this to the Issues 6.0.12.29 milestone May 25, 2019
@d2phap d2phap closed this as completed May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants