Additional #773 / #881 refactoring based on Roslyn #813
Conversation
Source/Components/ImageGlass.Library/Comparer/StringLogicalComparer.cs
Outdated
Show resolved
Hide resolved
I updated the name of |
|
@d2phap Hey there. Per your suggestion on editorconfig, I was able to bring in an updated copy of that, and align it to the code style you've been expressing on here. You prefer "K&R" style for the functions; I do as well, but it was defaulting to "Allman" style. Also, the editorconfig was targeting VB.NET code; so I'm not sure it was working right. I hope this helps us both out; I learned a few things. |
|
Okay... I thought I was done, and then realized I hadn't had https://github.com/JosefPihrt/Roslynator installed during this process. That caught a lot of the multi-blank lines, trailing spaces, and potential performance issues. |
|
Last change of the night. When I was going over stuff, there was a recommendation by some devs to use https://github.com/Microsoft/vs-threading/blob/master/doc/analyzers/index.md . I was able to implement some of its suggestions; others will need further work later on. |
|
Thanks @unquietwiki |
|
@d2phap Thanks! Sorry about that refactoring error; I think it was an accident on my part going through the different projects. |
|
@unquietwiki no problem |
@d2phap
Okay, so I went over things and the Rosyln checkers I have in VS 2019 found some additional things. It allowed for some of the C# 8.x stuff (mainly using & switch changes); Sharpen still says there's more to do. I also flagged a number of things that aren't warnings or informative messages; particularly, there were 2-3 suggestions, that if used would make toolbar items disappear on use.
One issue I did find... at least on my system, the thumbnails feature crashes the program. But one, I've been with local thumbnails on my own system due to some computer issues; and two, the crash happens in the ImageListView component we're not presently modifying. Otherwise, I mentioned before on #811 that there was some confusion in the software attempting to use the wrong XML file for the default theme.
Hope this helps!