Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented #890: Implemented group images by directory option #891

Merged
merged 4 commits into from
Oct 18, 2020
Merged

Implemented #890: Implemented group images by directory option #891

merged 4 commits into from
Oct 18, 2020

Conversation

sunbinyuan
Copy link
Contributor

image

Implements #890

@sunbinyuan
Copy link
Contributor Author

I don't know if that's necessary but maybe refactoring the WindowsNaturalSort to only perform the StrCmpLogicalW operation might also be an option if you don't want the additional comparer for directories.

d2phap
d2phap approved these changes Oct 18, 2020
View reviewed changes
Copy link
Owner

@d2phap d2phap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunbinyuan !

@d2phap d2phap merged commit 0a356bb into d2phap:develop Oct 18, 2020
@sunbinyuan sunbinyuan deleted the issue_890 branch October 18, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2phap d2phap d2phap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunbinyuan @d2phap