Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cycles. #1

Open
elmart opened this issue Feb 15, 2016 · 6 comments
Open

Support cycles. #1

elmart opened this issue Feb 15, 2016 · 6 comments

Comments

@elmart
Copy link

elmart commented Feb 15, 2016

Hi, I searched for sankey cycles support and found some issues debating this some time ago. Among approaches with some working code, perhaps https://github.com/soxofaan/d3-plugin-captain-sankey seems the most interesting. It seems his author expected it to be subsumed into an official d3 repo (which I presume would be this one) at some point. But it's not clear to me what has happened since.

What's the status of this?
Thanks.

@ghost
Copy link

ghost commented Feb 15, 2016

Hi Eliseo,

As you yourself have noted in this issue the project seems to be mostly inactive, which the author has confirmed in another issue.

The author has not contacted either me or Mike Bostock to my knowledge, so I'm not sure about whether it was their intention to merge their changes into this repository.

However, it seems like the change you want regarding reverse-links could be implemented. I will take a closer look at this later this weekend and will keep this issue open till this is resolved. If you have further comments or suggestions, feel free to leave them here.

Thanks!

@elmart
Copy link
Author

elmart commented Feb 15, 2016

Ok, I'll wait to hear from you.
Thx very much for your prompt response.

@freeeve
Copy link

freeeve commented Jul 28, 2016

At a minimum it would be nice if it didn't cause an infinite loop if a cycle exists. (just pretend that link doesn't exist, for example.)

@jkatsnelson
Copy link

jkatsnelson commented Dec 30, 2016

I just ran into this issue while using d3-sankey :(

monfera added a commit to monfera/d3-sankey that referenced this issue Apr 12, 2017
Stable sorting links for better parallel edge handling
@mbostock mbostock changed the title Cycles support Support cycles. Jun 12, 2017
@mbostock
Copy link
Member

mbostock commented Sep 1, 2019

As of version 0.9.1 (ef0ca63), we throw an error rather than going into an infinite loop.

@peteruithoven
Copy link

There are two alternatives that do support circulair links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants