Fix #27 - inaccurate timeout delay. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If timers are expensive, then by the time we sleep, the current time may have advanced substantially from the `clockNow` computed on wake. Therefore we must recompute the current time before scheduling the timeout.
|
Thanks for fixing this so quickly! Now it works as expected 😄. Will you be making a release of it any time soon? I just published the d3-graphviz plugin. The demos contain workarounds for this issue that I would like to remove. If you're interested, the demos are here: |
|
Is there any particular reason this didn't make it into d3/d3 v4.10.1? Anything I can do to help? |
|
No particular reason—I just forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If timers are expensive, then by the time we sleep, the current time may have advanced substantially from the
clockNowcomputed on wake. Therefore we must recompute the current time before scheduling the timeout.