Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(subscription): support fallbacking to pull subscription via 'proxy' #55

Merged
merged 6 commits into from
Jul 7, 2023
Merged

feat(subscription): support fallbacking to pull subscription via 'proxy' #55

merged 6 commits into from
Jul 7, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 2, 2023 •
edited
Loading

Background

Changes

  1. Check out dae-core to branch chore_expose_dialer to get the ability to invoke RouteDial. chore: expose the routable dialer for dae-wing dae#172
  2. Support to pull subscriptions by fall backing to use proxy.

@mzz2017 mzz2017 requested a review from kunish as a code owner July 2, 2023 04:04
kunish
kunish previously approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunish
Copy link
Member

kunish commented Jul 2, 2023

image

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 2, 2023

Fixed

@kunish
Copy link
Member

kunish commented Jul 2, 2023

@mzz2017 ok

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 2, 2023

image Looks good.

@dae-prow
Copy link
Contributor

dae-prow bot commented Jul 2, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

dae-prow[bot]
dae-prow bot previously approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 added tested and removed tested labels Jul 2, 2023
dae-prow[bot]
dae-prow bot approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@kunish
Copy link
Member

kunish commented Jul 5, 2023

Dont know if this had been fully tested, if so, consider merging it

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 7, 2023

Dont know if this had been fully tested, if so, consider merging it

Please approve it.

@mzz2017 mzz2017 requested a review from kunish July 7, 2023 09:23
@mzz2017 mzz2017 merged commit aac3753 into main Jul 7, 2023
@mzz2017 mzz2017 deleted the feat_update_sub_via_proxy branch July 7, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

@kunish kunish Awaiting requested review from kunish

Assignees

@mzz2017 mzz2017

Labels
feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzz2017 @kunish