Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trojan): potential panic due to incorrect n returned by ReadFrom #109

Merged
merged 2 commits into from
Jun 4, 2023
Merged

fix(trojan): potential panic due to incorrect n returned by ReadFrom #109

merged 2 commits into from
Jun 4, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented May 30, 2023 •
edited
Loading

Background

111

Checklist

  • The Pull Request has been fully tested

Full changelog

Pre-work

This PR should be considered to merge after #80

@mzz2017 mzz2017 marked this pull request as draft May 30, 2023 15:11
@mzz2017 mzz2017 changed the title fix: potential panic due to incorrect n returned by ReadFrom fix(trojan): potential panic due to incorrect n returned by ReadFrom May 30, 2023
@piyoki piyoki added the fix label May 30, 2023
@mzz2017 mzz2017 marked this pull request as ready for review June 4, 2023 03:41
kunish
kunish approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable enough

@mzz2017 mzz2017 merged commit ebe51f1 into main Jun 4, 2023
@mzz2017 mzz2017 deleted the fix_trojan_potential_panic branch June 4, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunish kunish kunish approved these changes

Assignees

@mzz2017 mzz2017

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzz2017 @kunish @piyoki