fix: new control plane should reset grpc conn pool cache #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyoki
reviewed
Jun 18, 2023
@yqlbu Yes, everything works fine. |
piyoki
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Problem
We may change gRPC node configuration, but the changed configuration is hard to apply due to the long connection and connection reuse feature of gRPC.
How to reproduce
Context is #111. (This PR does not fix it)
If we change
allow_insecurefrom false to true, and reload dae; the node remains not working.Checklist
Full changelogs