Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support unknown qtype and upgrade go mod #180

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 7, 2023

Background

Some new qtype is not supported by dae. See more: #167

This PR fixes it.

Checklist

Full changelogs

  • Support pure number as the qtype.
  • Upgrade go modules.

Related

#167

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 7, 2023

@umlka Could you help test it?

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 7, 2023

image

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 34dfd7a into main Jul 7, 2023
@mzz2017 mzz2017 deleted the feat_unknown_dnstype branch July 7, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant