Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: No AddrPort presented #207

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix: No AddrPort presented #207

merged 1 commit into from
Jul 11, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 11, 2023 •
edited
Loading

Background

image

image

This problem deepened since #203. However, this problem exists for a long time.

This PR fixes it.

Checklist

Full changelogs

  • Pass in a copy of oob into the goroutine instead of reusing it.

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 11, 2023 •
edited
Loading

Test result:
image
image

dae-prow[bot]
dae-prow bot approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 9c5159f into main Jul 11, 2023
@mzz2017 mzz2017 deleted the fix_No_AddrPort_presented branch July 11, 2023 15:14
@mzz2017 mzz2017 mentioned this pull request Jul 12, 2023
Merged
@piyoki piyoki mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

Assignees

@mzz2017 mzz2017

Labels
fix tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mzz2017