Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support juicity #248

Merged
merged 7 commits into from
Jul 29, 2023
Merged

feat: support juicity #248

merged 7 commits into from
Jul 29, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 28, 2023 •
edited
Loading

Background

Support juicity.

Checklist

Full changelogs

@mzz2017 mzz2017 requested a review from a team as a code owner July 28, 2023 16:02
@piyoki piyoki requested a review from a team July 28, 2023 16:15
@dae-prow
Copy link
Contributor

dae-prow bot commented Jul 28, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@mzz2017 mzz2017 requested a review from a team as a code owner July 28, 2023 18:10
@piyoki
Copy link
Contributor

piyoki commented Jul 29, 2023

I’ll open a discussion page in a sec.

dae-prow[bot]
dae-prow bot approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

kunish
kunish approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzz2017 mzz2017 merged commit e4a95aa into main Jul 29, 2023
23 checks passed
@mzz2017 mzz2017 deleted the feat_juice branch July 29, 2023 15:41
@dae-prow dae-prow bot mentioned this pull request Jul 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

@piyoki piyoki piyoki approved these changes

@kunish kunish kunish approved these changes

Assignees

@mzz2017 mzz2017

Labels
feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzz2017 @piyoki @kunish