Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bad ipversion selection caused by #251 #257

Merged
merged 2 commits into from
Aug 5, 2023
Merged

fix: bad ipversion selection caused by #251 #257

merged 2 commits into from
Aug 5, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Aug 5, 2023 •
edited
Loading

Background

dae always chooses ipv6 DNS to dial which causes no network.

Reproduce conditions:

  1. The group only has one node.
  2. DNS upstream uses domain, thus dae can select between ipv4 and ipv6.
  3. Remote proxy doesn't support ipv6.

Checklist

Full changelogs

  • Return 10*second (timeout) instead of 0ms as latency if there is no alive dialer for a given network type.
  • Refine code.
  • Upgrade go module softwind.

https://github.com/daeuniverse/dae/pull/257/files#diff-60d7f789fcd6cccaaeca0f229f53ffdff0ce5586805cb6f1908db25619f361f8R236-R245

Related PR

#251

Test Result

@mzz2017 mzz2017 requested a review from a team as a code owner August 5, 2023 04:09
piyoki
piyoki approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@piyoki piyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

dae-prow[bot]
dae-prow bot approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit a638242 into main Aug 5, 2023
22 checks passed
@mzz2017 mzz2017 deleted the fix_ipversion_selection branch August 5, 2023 10:18
@dae-prow dae-prow bot mentioned this pull request Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

@piyoki piyoki piyoki approved these changes

@kunish kunish kunish approved these changes

Assignees

@mzz2017 mzz2017

Labels
fix tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzz2017 @kunish @piyoki