Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caddy cannot accept connections #262

Merged
merged 3 commits into from
Aug 5, 2023
Merged

fix: caddy cannot accept connections #262

merged 3 commits into from
Aug 5, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Aug 5, 2023

Background

Caddy and samba cannot work.

This may be some special use of their listening socket, because bpf_assign returns -94 (ESOCKTNOSUPPORT).

This problem is NOT about PSH flag of TCP.

This is most likely because the caddy port has enabled IP_TRANSPARENT sockopt.

Checklist

Full changelogs

  • Just accept the skb once bpf_assign returns -94 (ESOCKTNOSUPPORT).
  • Deprecate CFLAGS -D__REMOVE_BPF_PRINTK

Issue reference

Closes #261. Related #154.

Test Result

@mzz2017 mzz2017 requested a review from a team as a code owner August 5, 2023 17:05
@mzz2017 mzz2017 requested review from a team as code owners August 5, 2023 17:32
@dae-prow
Copy link
Contributor

dae-prow bot commented Aug 5, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@mzz2017
Copy link
Contributor Author

mzz2017 commented Aug 5, 2023

Test Result:
image

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 7ef8205 into main Aug 5, 2023
23 checks passed
@mzz2017 mzz2017 deleted the fix_caddy_samba branch August 5, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

和 caddy 服务器一起使用时 caddy 无法正常工作
2 participants