Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add -buildmode=pie #266

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

shenghuang147
Copy link
Contributor

Background

Checklist

Full changelogs

  • [Implement ...]

Issue reference

Closes #[issue number]

Test Result

@shenghuang147 shenghuang147 requested a review from a team as a code owner August 8, 2023 16:06
@dae-prow dae-prow bot added the chore label Aug 8, 2023
@kunish
Copy link
Member

kunish commented Aug 8, 2023

Have you tested this locally?

Move the -buildmode=pie flag from the -ldflags parameter to the go build command, to make the compilation process more clear and standard.

The -buildmode=pie flag is used to generate position independent executable (PIE) files, which can improve the security and compatibility of the program. It should not be confused with the -ldflags parameter, which is used to pass flags to the linker.

This change does not affect the functionality or performance of the program, but it makes the code more readable and maintainable.
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants