Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support --abort for reload and suspend #346

Merged
merged 2 commits into from
Nov 14, 2023
Merged

feat: support --abort for reload and suspend #346

merged 2 commits into from
Nov 14, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Oct 21, 2023 •
edited by piyoki
Loading

Background

dae reload/suspend [pid] [flags]
Flags:
  -a, --abort   Abort established connections.

Checklist

Full Changelogs

  • feat: support --abort for reload and suspend

Issue Reference

Closes #[issue number]

Test Result

@mzz2017 mzz2017 requested a review from a team as a code owner October 21, 2023 16:51
dae-prow[bot]
dae-prow bot approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 9f7a49b into main Nov 14, 2023
22 checks passed
@mzz2017 mzz2017 deleted the feat_reload_suspend_with_aborting branch November 14, 2023 08:26
@dae-prow dae-prow bot mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

@piyoki piyoki piyoki approved these changes

Assignees

@mzz2017 mzz2017

Labels
feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzz2017 @piyoki