Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cmd/version): update print info #417

Merged
merged 3 commits into from
Jan 22, 2024
Merged

chore(cmd/version): update print info #417

merged 3 commits into from
Jan 22, 2024

Conversation

sumire88
Copy link
Contributor

@sumire88 sumire88 commented Jan 8, 2024

Background

As the title suggests.

Checklist

Full Changelogs

  • chore(cmd/version): update print info

Issue Reference

NA

@sumire88 sumire88 self-assigned this Jan 8, 2024
@sumire88 sumire88 requested a review from a team as a code owner January 8, 2024 12:58
@dae-prow dae-prow bot added the chore label Jan 8, 2024
@sumire88 sumire88 added the tested label Jan 8, 2024
dae-prow[bot]
dae-prow bot approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

mzz2017
mzz2017 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sumire88 sumire88 merged commit db8f474 into main Jan 22, 2024
30 checks passed
@sumire88 sumire88 deleted the version-print-patch branch January 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

@mzz2017 mzz2017 mzz2017 approved these changes

Assignees

@sumire88 sumire88

Labels
chore tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumire88 @mzz2017