Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(example.dae): add node selection by tag #44

Merged
merged 3 commits into from
Mar 26, 2023
Merged

doc(example.dae): add node selection by tag #44

merged 3 commits into from
Mar 26, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Mar 26, 2023

Summary

Add an example to select target nodes by tag.

@piyoki piyoki added the documentation Improvements or additions to documentation label Mar 26, 2023
@piyoki piyoki self-assigned this Mar 26, 2023
@piyoki piyoki requested a review from mzz2017 as a code owner March 26, 2023 04:09
example.dae Outdated
@@ -119,6 +121,8 @@ group {
group2 {
# Filter nodes from the global node pool defined by the subscription and node section above.
filter: subtag(regex: '^my_', another_sub) && !name(keyword: 'ExpireAt:')
# Filter nodes from the global node pool defined by tag
# filter: name(node1, node2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest:

        # Filter nodes from the global node pool defined by tag
        #filter: name(node1, node2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved.

@mzz2017 mzz2017 merged commit 1bbb93f into daeuniverse:main Mar 26, 2023
@piyoki piyoki deleted the node-selection branch March 26, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants