-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: auto_config_kernel_parameter sets net.ipv6.conf.all.forwarding=1 when binding lan interfaces #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
这个影响 bind lan 还是都影响?如果只影响 bind lan,可以加在 bindlan 函数里 |
jschwinger233
force-pushed
the
gray/ipv6-fwd
branch
from
April 14, 2024 15:11
cd3af5f
to
dcfaa1e
Compare
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
mzz2017
reviewed
Apr 14, 2024
mzz2017
reviewed
Apr 14, 2024
jschwinger233
force-pushed
the
gray/ipv6-fwd
branch
from
April 14, 2024 15:24
6fbe982
to
23b8ad0
Compare
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
jschwinger233
changed the title
fix: sysctl net.ipv6.conf.all.forwarding=1 inside netns
fix: auto_config_kernel_parameter sets net.ipv6.conf.all.forwarding=1 when binding lan interfaces
Apr 14, 2024
mzz2017
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 Since the PR has been fully tested, please consider merging it.
sumire88
approved these changes
Apr 14, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Previous PR #496 turns out to be causing problem as reported by #498, this PR fixes the issue.
Checklist
Full Changelogs
Issue Reference
Closes #498
Test Result