Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto_config_kernel_parameter sets net.ipv6.conf.all.forwarding=1 when binding lan interfaces #499

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Apr 13, 2024

Background

Previous PR #496 turns out to be causing problem as reported by #498, this PR fixes the issue.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #498

Test Result

@mzz2017
Copy link
Contributor

mzz2017 commented Apr 14, 2024

这个影响 bind lan 还是都影响?如果只影响 bind lan,可以加在 bindlan 函数里

@dae-prow
Copy link
Contributor

dae-prow bot commented Apr 14, 2024

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@dae-prow
Copy link
Contributor

dae-prow bot commented Apr 14, 2024

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@jschwinger233 jschwinger233 marked this pull request as ready for review April 14, 2024 16:09
@jschwinger233 jschwinger233 requested review from a team as code owners April 14, 2024 16:09
@jschwinger233 jschwinger233 added the documentation Improvements or additions to documentation label Apr 14, 2024
@jschwinger233 jschwinger233 changed the title fix: sysctl net.ipv6.conf.all.forwarding=1 inside netns fix: auto_config_kernel_parameter sets net.ipv6.conf.all.forwarding=1 when binding lan interfaces Apr 14, 2024
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@sumire88 sumire88 merged commit c091694 into main Apr 15, 2024
29 checks passed
@sumire88 sumire88 deleted the gray/ipv6-fwd branch April 15, 2024 00:17
@dae-prow dae-prow bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fix tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] 移除 net.ipv6.conf.all.forwarding=1 后在某些场景下似乎存在一些问题
3 participants