Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support to report all error when reloading #540

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 14, 2024

Background

In the past, not all problems would be reported when reloading, such as non-existent group name error. This PR fixes it.

Related: #470

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

image

@mzz2017 mzz2017 requested a review from a team as a code owner June 14, 2024 17:43
@TnZzZHlp
Copy link

TnZzZHlp commented Jun 15, 2024

测了下reload可以正常检测到原本检测不到的错误了👍
image

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 795bd05 into main Jun 15, 2024
29 checks passed
@mzz2017 mzz2017 deleted the mzz/fix_reloading_err_report branch June 15, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants