Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(udp_task_pool): panic: close of closed channel #570

Merged
merged 5 commits into from
Jul 15, 2024
Merged

fix(udp_task_pool): panic: close of closed channel #570

merged 5 commits into from
Jul 15, 2024

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 30, 2024 •
edited
Loading

Background

panic: close of closed channel

goroutine 358834 [running]:
github.com/daeuniverse/dae/control.(*UdpTaskPool).EmitTask.func1()
  github.com/daeuniverse/dae/control/udp_task_pool.go:81 +0xf4
created by time.goFunc
  time/sleep.go:177 +0x2d

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@mzz2017 mzz2017 requested a review from a team as a code owner June 30, 2024 11:08
dae-prow[bot]
dae-prow bot approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 5810244 into main Jul 15, 2024
29 checks passed
@mzz2017 mzz2017 deleted the mzz2017-patch-1 branch July 15, 2024 05:30
This was referenced Jul 15, 2024
Merged
Closed
sumire88 pushed a commit that referenced this pull request Aug 21, 2024
@mzz2017 @sumire88
fix(udp_task_pool): panic: close of closed channel (#570)
ef9690a 
(cherry picked from commit 5810244)
mnixry pushed a commit to mnixry/dae that referenced this pull request Sep 18, 2024
@mzz2017 @mnixry
fix(udp_task_pool): panic: close of closed channel (daeuniverse#570)
719657b
@dae-prow dae-prow bot mentioned this pull request Sep 27, 2024
Closed
@dae-prow dae-prow bot mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

@MarksonHon MarksonHon MarksonHon approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

Assignees

@mzz2017 mzz2017

Labels
fix tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzz2017 @jschwinger233 @MarksonHon