Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: persistent subscription #577

Merged
merged 1 commit into from
Jul 15, 2024
Merged

docs: persistent subscription #577

merged 1 commit into from
Jul 15, 2024

Conversation

st0nie
Copy link
Contributor

@st0nie st0nie commented Jul 10, 2024

Background

Some times it may not be possible to pull the subscription when the network is poor, which can lead to users not being able to function properly if they are completely dependent on the subscription.(no node exists in the group)

Add documentation for persistent subscriptions to help users avoid this issue.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@st0nie st0nie requested a review from a team as a code owner July 10, 2024 14:44
@dae-prow dae-prow bot added the documentation Improvements or additions to documentation label Jul 10, 2024
mzz2017
mzz2017 previously approved these changes Jul 10, 2024
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty cool. I think it will be useful to a lot of people. Thanks for your contribution, let's help make dae better together.

@umlka
Copy link

umlka commented Jul 11, 2024

建议增加一个UA

@douglarek
Copy link
Contributor

douglarek commented Jul 12, 2024

Frankly speaking, this thing should be implemented in the code rather than being mixed up in the documentation. For example, add retries and scheduled updates.

MarksonHon
MarksonHon previously approved these changes Jul 13, 2024
@mzz2017 mzz2017 merged commit ffdfadb into daeuniverse:main Jul 15, 2024
3 checks passed
@mzz2017
Copy link
Contributor

mzz2017 commented Jul 15, 2024

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants